-
Notifications
You must be signed in to change notification settings - Fork 6
meta(changelog): Update package versions #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit seems to be all about version bump and logging improvemnets across different packages in the repository. The new versions for the packages are set correctly in the package.json and the changelog is updated for all the respective packages. The commit can be approved as the logging improvements do not look to affect any functional part of the code.
|
|
||
| ### Minor Changes | ||
|
|
||
| - 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to test the changes in a staging environment or add some unit tests for the logging improvements.
| ### Patch Changes | ||
|
|
||
| - Updated dependencies [6c4377d] | ||
| - @codecov/bundler-plugin-core@1.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to see that dependencies are updated with the version bump.
| { | ||
| "name": "@codecov/bundle-analyzer", | ||
| "version": "1.1.0", | ||
| "version": "1.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version bump here seems to follow the semantic versioning correctly.
|
|
||
| ### Minor Changes | ||
|
|
||
| - 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a minor version update, please make sure that these changes will not cause any breaking changes.
| - @codecov/bundler-plugin-core@1.2.0 | ||
| - @codecov/vite-plugin@1.2.0 | ||
|
|
||
| ## 1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Effective use of a changelog. It will be helpful to see when and what changes were introduced in each update.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@codecov/solidstart-plugin", | |||
| "version": "1.1.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that the updated version number is also reflected in any documentation or 'ReadMe' files that may reference these package versions.
| ### Minor Changes | ||
|
|
||
| - 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see dependencies also up to date. It would prevent potential out-of-sync issues.
|
|
||
| - 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present. | ||
|
|
||
| ### Patch Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When updating the changelog, it would be helpful to add a bit more context about the improvements to the debug logging to inform users.
suejung-sentry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved! do we need to update all the version numbers in the integration tests too?
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Bundle ReportBundle size has no change ✅
|
Bundle ReportChanges will increase total bundle size by 3 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@codecov/[email protected]
Minor Changes
Patch Changes
@codecov/[email protected]
Minor Changes
@codecov/[email protected]
Minor Changes
Patch Changes
@codecov/[email protected]
Minor Changes
Patch Changes
@codecov/[email protected]
Minor Changes
Patch Changes
@codecov/[email protected]
Minor Changes
Patch Changes
@codecov/[email protected]
Minor Changes
Patch Changes
@codecov/[email protected]
Minor Changes
Patch Changes
@codecov/[email protected]
Minor Changes
Patch Changes
@codecov/[email protected]
Minor Changes
Patch Changes